dblaikie added a comment.

This'll need a test case & does the change pass all existing tests?
Also, the patch description could use more detail - it can refer to the bug for 
more context, but there should be enough detail in the patch title/description 
to understand the general purpose, etc. (and you can shorten the bug reference 
to "PR50774" rather than the whole bugs.llvm.org URL)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104619/new/

https://reviews.llvm.org/D104619

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to