nickdesaulniers added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:201-205 + // Call getAArch64ArchFeaturesFromMarch only if "-Wa,-march=" or + // "-Xassembler -march" is detected. Otherwise it may return false + // and causes Clang to error out. + if (WaMArch.size()) + success = getAArch64ArchFeaturesFromMarch(D, WaMArch, Args, Features); ---------------- If this surprised us before, it's likely to surprise us (or someone else) again. In that case, I'd recommend permitting `getAArch64ArchFeaturesFromMarch` to accept an empty second parameter, and simply `return true` early. Then callers don't need such a check and comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
