aaronpuchert added inline comments.
================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2227-2228
/// \param LEK2 The error message to report if a mutex is missing from Lset2
void ThreadSafetyAnalyzer::intersectAndWarn(FactSet &FSet1,
const FactSet &FSet2,
SourceLocation JoinLoc,
----------------
aaronpuchert wrote:
> Presumably we should call these `EntrySet` and `ExitSet` instead? The second
> parameter is always the exit set of an existing block, the first parameter
> the entry set of a (sometimes new) block.
Did this in a separate change D104649, because it would obfuscate the changes
here. Nevertheless, it's probably a good idea to look at both changes together.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104261/new/
https://reviews.llvm.org/D104261
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
