dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
Sounds OK to me. Another thing you might want to check is linkonce_odr functions - I guess you'll get an arbitrary choice between two linkonce_odr functions under LTO where they have different warn-stack-size? Maybe there's a way/place to merge and always pick the lower or upper value if there's one you think would be more right? ================ Comment at: llvm/test/Transforms/Inline/warn-stack-size.ll:1 +; RUN: opt -passes=inline -S %s | FileCheck %s + ---------------- Nice to see the test - though I probably wouldn't bother adding this test if this behavior already falls out of more general support in the inliner and the way it already handles attributes - the general behavior is likely already tested elsewhere? (though it'd be good to confirm that either in tests and/or the inliner code itself) my original question was to confirm that the inliner already had accounted for this situation in a way that was desirable & it looks like/sounds like it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ https://reviews.llvm.org/D104342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
