aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed.
This change breaks code by removing the `[[clang::no_sanitize]]` spelling (and the fact that zero tests broke show we're missing test coverage here). We don't currently have a spelling to represent an attribute known to both Clang and GCC, nor do we currently have any attributes that use both the `Clang` and `GCC` spellings (which both include a `GNU` spelling that would be duplicated). I think you should keep the `Clang` spelling, add a `GCC` spelling, make sure that ClangAttrEmitter.cpp does not generate two `GNU` spellings for it, and add some basic test coverage for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104491/new/ https://reviews.llvm.org/D104491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
