bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land.
> Assuming I'm answering the correct question that the returns_nonnull is > preserved through a PCH, the answer is yes. Thanks! > As mentioned this isn't strictly needed and the BE can elide the check but we > can also not emit it to save on AST/IR processing cost. It's a good way for clang based tooling to get the expected result if relying on `shouldNullCheckAllocation` for an accurate answer. Maybe wait a few more days to see if anyone else has any comment, otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102820/new/ https://reviews.llvm.org/D102820 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
