waltl added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:761
+  // There's no libpthread or librt on Android.
+  if (!TC.getTriple().isAndroid()) {
     CmdArgs.push_back("-lpthread");
----------------
Just to be super cautious, can be keep this line and the one below in regard to 
libdl below?  RTEMS is an open source project so it's conceivable that someone 
may be using clang for it.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:769
   if (!TC.getTriple().isOSFreeBSD() && !TC.getTriple().isOSNetBSD() &&
-      !TC.getTriple().isOSOpenBSD() &&
-      TC.getTriple().getOS() != llvm::Triple::RTEMS)
+      !TC.getTriple().isOSOpenBSD())
     CmdArgs.push_back("-ldl");
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104279/new/

https://reviews.llvm.org/D104279

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to