stuart added a comment. This looks good to me.
@jzzheng22 informs me there was a comment in D99250 <https://reviews.llvm.org/D99250> to the effect that DW_LANG_C_plus_plus_03 is not emitted, at all - it too was introduced in DWARF 5. I wonder if this should be addressed in a separate commit? As mentioned in D104118 <https://reviews.llvm.org/D104118>, there are language codes of DW_LANG_C_plus_plus_17 and DW_LANG_C_plus_plus_20 that will be introduced in DWARF 6, which it would be good to use in non-strict mode. This would allow us to emit the more proper code of DW_LANG_C_plus_plus_17 (instead of DW_LANG_C_plus_plus_14) for //C++ for OpenCL//, while we wait for DW_LANG_CPP_for_OpenCL to get added, as requested at http://dwarfstd.org/ShowIssue.php?issue=210514.1. Should this be addressed in a third commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104291/new/ https://reviews.llvm.org/D104291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
