amccarth added a comment. Nice catch Reid.
================ Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, + Binary ? llvm::sys::fs::OF_None + : llvm::sys::fs::OF_Text)); + OSFile = std::string(TempPath.str()); ---------------- rnk wrote: > I think the bug is here: the third parameter is `bool unbuffered`, not file > flags, so we are opening the file for unbuffered writing, and that is really > slow. Yowza! In addition to a fix, we need some memes. * Why do we even have that lever? * This constructor has too many overloads. Please remove three. * [Facepalm] `bool` parameters. [Double facepalm] Negative `bool` parameter names that default to `false`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
