feg208 marked an inline comment as done. feg208 added a comment. addressed the remaining review comment
================ Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 + struct test demo[] = + { + {56, 23, "hello"}, + {-1, 93463, "world"}, + { 7, 5, "!!"} + }; ---------------- curdeius wrote: > feg208 wrote: > > curdeius wrote: > > > Don't forget to re-generate .rst. > > I am sorry. I am not entirely sure what to check here? Should I regenerate > > the docs for the site and just ensure that they look ok? > It seems that you modified Format.h but didn't re-run > `clang/docs/tools/dump_format_style.py` (example for `Left` is actually > right-aligned). Got it. Sorry for the confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits