keith created this revision.
keith added a reviewer: thakis.
keith requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This crasher was fixed with Xcode 13.0 beta 1 / ld64 705. This is an
updated revert of https://reviews.llvm.org/D92357
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D103934
Files:
clang/lib/Driver/ToolChains/Darwin.cpp
Index: clang/lib/Driver/ToolChains/Darwin.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -711,10 +711,7 @@
}
ResponseFileSupport ResponseSupport;
- if (LinkerIsLLDDarwinNew) {
- // Xcode12's ld64 added support for @response files, but it's crashy:
- // https://openradar.appspot.com/radar?id=4933317065441280
- // FIXME: Pass this for ld64 once it no longer crashes.
+ if (Version[0] >= 705 || LinkerIsLLDDarwinNew) {
ResponseSupport = ResponseFileSupport::AtFileUTF8();
} else {
// For older versions of the linker, use the legacy filelist method
instead.
Index: clang/lib/Driver/ToolChains/Darwin.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -711,10 +711,7 @@
}
ResponseFileSupport ResponseSupport;
- if (LinkerIsLLDDarwinNew) {
- // Xcode12's ld64 added support for @response files, but it's crashy:
- // https://openradar.appspot.com/radar?id=4933317065441280
- // FIXME: Pass this for ld64 once it no longer crashes.
+ if (Version[0] >= 705 || LinkerIsLLDDarwinNew) {
ResponseSupport = ResponseFileSupport::AtFileUTF8();
} else {
// For older versions of the linker, use the legacy filelist method instead.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
