aaron.ballman added a comment.

Thank you for the terminology cleanup! I'm not opposed to the changes, but I am 
wondering whether the churn is worth it given that the nomenclature will still 
be confusing for those thinking about non-C++ based languages (esp if someone 
in the future wants to add `Expr::isRValue()` with the C++ meaning of prvalue 
|| xvalue). Either way, I think the confusion will likely be relatively minor 
and temporary.

@rsmith, what say you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103720/new/

https://reviews.llvm.org/D103720

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to