aaron.ballman added a comment. In D103885#2805217 <https://reviews.llvm.org/D103885#2805217>, @protze.joachim wrote:
> I don't think, this needs ifdefs. As I understand, a compiler is supposed to > ignore unknown pragmas. It does. You can see it produces diagnostics in `-Wall` mode in GCC and it produces diagnostics at any warning level in MSVC or ICC (https://godbolt.org/z/58nqGx14o). We don't use it often in the code base, but the very select places we've done it, we've protected it (https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/Hexagon/HexagonDepDecoders.inc#L12, https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/ADT/StringRef.h#L878 which are the only two non-test places in the Clang + LLVM + extra code base we've done this before). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103885/new/ https://reviews.llvm.org/D103885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
