jcai19 added a comment. In D103184#2803768 <https://reviews.llvm.org/D103184#2803768>, @thakis wrote:
> FWIW the failure goes away locally if I revert this change here, so it's > definitely due to this change here. > > Things have been red for a while, probably good to revert while you > investigate by this point. Okay, will revert it shortly if i can't find a fix soon. Sorry for the delay, i just finished In D103184#2803768 <https://reviews.llvm.org/D103184#2803768>, @thakis wrote: > FWIW the failure goes away locally if I revert this change here, so it's > definitely due to this change here. > > Things have been red for a while, probably good to revert while you > investigate by this point. I just pushed a revert. Sorry for the delay, my macbook had some issues building LLVM so had to fix them first. In D103184#2803768 <https://reviews.llvm.org/D103184#2803768>, @thakis wrote: > FWIW the failure goes away locally if I revert this change here, so it's > definitely due to this change here. > > Things have been red for a while, probably good to revert while you > investigate by this point. Sorry for the delay but my macbook had some issues so I just finished building LLVM, but I can't seem to reproduce this issue locally (neither running the test directly with llvm-lit nor `ninja check-clang`). In fact I don't quite understand why this failure happened. Like @nickdesaulniers mentioned the build failure should have been fixed in https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5 for a different patch. Do you mind sharing the instructions you used to reproduce the test failure? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
