Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! Thanks. Considering that this patch doesn't add anything new to the design, I suggest we go ahead. But we should continue the discussion around -cl-ext etc elsewhere and then perhaps some follow up patches will be needed to fix this fully. ================ Comment at: clang/test/Headers/opencl-c-header.cl:154 // OpenCL C features. -#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ == 200) +#if (__OPENCL_C_VERSION__ == 300) + ---------------- btw I think we are not testing that the macros are not defined for other targets than SPIR, but I guess this deserves a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
