sammccall added a subscriber: rsmith. sammccall added a comment. This seems sensible to me but hard to know if it's going to be an improvement in practice. Can you paste a realistic example?
@rsmith any opinion about this diag? ================ Comment at: clang/test/Modules/declare-use1.cpp:6 #include "e.h" -#include "f.h" // expected-error {{module XG does not depend on a module exporting 'f.h'}} +#include "f.h" // expected-error-re {{module XG does not depend on a module exporting '{{.*}}{{/|\\}}f.h'}} #include "i.h" ---------------- I'd be tempted to leave the slashes in the globs for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103797/new/ https://reviews.llvm.org/D103797 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits