sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land.
LGTM, thanks @HsiangKai ================ Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -std=c++11 -triple riscv64 -target-feature +experimental-v \ +// RUN: -emit-llvm -O1 -o - %s | FileCheck %s ---------------- craig.topper wrote: > sdesmalen wrote: > > craig.topper wrote: > > > Probably best to add -disable-llvm-passes so we don't run the optimizer. > > nit: Does `-O1` still have any effect if `-disable-llvm-passes` is also set? > Lifetime markers aren't emitted with -O0. I didn't know that, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
