adamcz marked an inline comment as done. adamcz added a comment. I didn't put much thought into where --check-lines goes. It's an interesting thought.
I think having all the flags in one place is more valuable than trying to split them in some way. We contain all flags in the same place, close to main() and check() gets all it's data from arguments, rather than some side channel. It makes check() easier to re-use and/or test. It also allows us to complain about flag misuse, such as specifying --check-lines without --check, etc. I'm going to commit as-is, since you LGTMed this, but feel free to continue discussion here and if we decide to move the flags somewhere else I'll happily submit another change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/new/ https://reviews.llvm.org/D103538 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
