aaron.ballman added inline comments.
================ Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If unsafe floating point optimizations are ---------------- mibintc wrote: > aaron.ballman wrote: > > We may need to expound on what "honor parentheses" means. The summary for > > the patch mentions `(a + b) + c`, but does this also mean `(x + y) * z` > > could be interpreted as `x + (y * z)`? What about for non-arithmetic > > expressions involving parentheses, like `(float1 == float2 && float1 == > > float3) || blah()`? > Thanks for your review. Just a quick first response, What do you mean "(x + > y) * z could be reinterpreted as x + (y * z)" -- not following you here? "whether the optimizer honors the parentheses" reads to me like `(x + y) * z` could either honor or not honor the parentheses, so that could either evaluate as `(x + y) * z` or `x + (y * z)` depending on whether the parens are honored or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
