tra added inline comments.
================ Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 // NEG-NOT: @_ZL13var_host_only -// NEG-NOT: external +// NEG-NOT: external addrspace ---------------- This may be too specific. What if we end up generating a variable in generic AS which does not have `addrspace`. Considering that we went to make sure we don't create references to external variables, we want something like this instead: ``` NEG-NOT: {{^}}@{{.*}} = external ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103658/new/ https://reviews.llvm.org/D103658 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits