dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM; thanks for you patience.

I've been a bit paralyzed, thinking about whether we could/should add a remark, 
something like `-Rtemp-file` or `-Routput-file`, which could be triggered when 
opening an output file. That would be a path toward testing this. On the other 
hand, I'm afraid maintaining the remark could restrict options in the future 
for output backends. For now let's just go with what you have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101775/new/

https://reviews.llvm.org/D101775

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D101775: F... Zachary Henkel via Phabricator via cfe-commits
    • [PATCH] D1017... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D1017... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D1017... Zachary Henkel via Phabricator via cfe-commits
    • [PATCH] D1017... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to