dblaikie added a comment. In D101566#2786112 <https://reviews.llvm.org/D101566#2786112>, @aaronpuchert wrote:
> In D101566#2785271 <https://reviews.llvm.org/D101566#2785271>, @dblaikie > wrote: > >> Right - to remove -Wweak-template-vtable in its entirety. The original >> implementation explicitly didn't warn on implicit instantiations and I think >> the fact that it warned on explicit instantiations is more bug than feature >> - and we should treat it that way. > > What about `-Wweak-vtables`, what's the reasoning for keeping that? That it doesn't seem to have major issues to me - so I'm willing to leave it there, even if it's questionable as to whether anyone uses it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101566/new/ https://reviews.llvm.org/D101566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
