bruno requested changes to this revision.
bruno added a comment.
This revision now requires changes to proceed.
Overall looks good, few remaining nitpicks.
================
Comment at: clang/lib/Lex/HeaderMap.cpp:245
+StringRef HeaderMapImpl::reverseLookupFilename(StringRef DestPath) const {
+ if (ReverseMap.empty()) {
+ const HMapHeader &Hdr = getHeader();
----------------
Please rewrite this to early return in case this isn't empty.
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1856
+ if (SearchDirs[I].isHeaderMap()) {
+ StringRef SpelledFilename =
+ SearchDirs[I].getHeaderMap()->reverseLookupFilename(Filename);
----------------
Similar from above: rewrite to early continue if it's not meeting the
conditions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103142/new/
https://reviews.llvm.org/D103142
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
