bruno accepted this revision.
bruno added a reviewer: rsmith.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for adding the tests. LGTM after some remaining nitpick.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11632
+ // As with enum-decls, we ignore attributes for now.
+
+ auto *Enum = cast<EnumDecl>(DS.getRepAsDecl());
----------------
Remove this empty line.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12339
+
+ if (!CheckUsingShadowDecl(UD, EC, Previous, PrevDecl)) {
+ BuildUsingShadowDecl(S, UD, EC, PrevDecl);
----------------
No need for curly braces here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102241/new/
https://reviews.llvm.org/D102241
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
