aaron.ballman added reviewers: rsmith, erichkeane. aaron.ballman added inline comments.
================ Comment at: clang/include/clang/AST/DeclCXX.h:2685 + bool UsesFPIntrin, bool isInline, + bool isImplicitlyDeclared, ConstexprSpecKind ConstexprKind, ---------------- Formatting looks off here. ================ Comment at: clang/include/clang/AST/DeclCXX.h:2729 : CXXMethodDecl(CXXConversion, C, RD, StartLoc, NameInfo, T, TInfo, - SC_None, isInline, ConstexprKind, EndLocation, + SC_None, false, isInline, ConstexprKind, EndLocation, TrailingRequiresClause), ---------------- If ctors and cxxmethods get the parameter, why not conversion operators? ================ Comment at: clang/lib/Sema/SemaLambda.cpp:395 MethodNameLoc), - MethodType, MethodTypeInfo, SC_None, + MethodType, MethodTypeInfo, SC_None, /*UsesFPIntrin*/ false, /*isInline=*/true, ConstexprKind, EndLoc, TrailingRequiresClause); ---------------- Should lambdas pick up the same fp constraints as the function defining the lambda? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits