Anastasia added inline comments.
================ Comment at: clang/lib/Sema/Sema.cpp:306 + // Set conditionally to provide correct diagnostics for 'double' type + llvm::StringRef FP64Feature( + getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64"); ---------------- azabaznov wrote: > Anastasia wrote: > > Technically both "__opencl_c_fp64" and "cl_khr_fp64" are required in > > OpenCL, perhaps we should report both in OpenCL 3? > Even better, can we merge this first https://reviews.llvm.org/D100976? This > is needed to completely remove such check for fp64. Sure I have committed it now: https://reviews.llvm.org/rG769cc335e6e63e5eac0c0ac849de44714326e20b Btw, I will also commit https://reviews.llvm.org/D101043 soon. That should hopefully remove the remianing confusions around pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
