fhahn added inline comments.

================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:405
     break;
+  case CodeGenOptions::Darwin_libsystem_m:
+    TLII->addVectorizableFunctionsFromVecLib(
----------------
arphaman wrote:
> fhahn wrote:
> > arphaman wrote:
> > > Can you add an IRGen testcase that verifies that TLII is setting the 
> > > vecLib correctly here?
> > Like a test that generates IR using a vector function from Darwin's 
> > libsystem m?
> Sure, I think that should cover this switch case.
I added `clang/test/CodeGen/veclib-darwin-libsystem-m.c` which should contain 
an end-to-end test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102489/new/

https://reviews.llvm.org/D102489

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to