fhahn added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492
+ // Darwin_libsystem_m for iOS based targets.
+ if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib))
+ CC1Args.push_back("-fveclib=Darwin_libsystem_m");
----------------
arphaman wrote:
> Is this applicable to the watchOS targets as well? The iOS based check
> doesn't cover it.
`libsystem_m`'s vector functions should be available on all Darwin platforms I
think. I'd gradually opt-in additional platforms, once we verified it is
clearly beneficial for each platform individually.
Should I add a TODO?
================
Comment at: clang/test/Driver/darwin-veclib-default.c:9
+
+// RUN: %clang -target arm64-apple-darwinos -S -### %s -arch arm64 2>&1 | \
+// RUN: FileCheck --check-prefix CHECK-IOS-DEFAULT %s
----------------
arphaman wrote:
> `darwinos` isn't a valid OS type, what's your intent with this testcase here?
Ah OK! Would it make sense to check `-darwin`? Or just `-iOS`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102494/new/
https://reviews.llvm.org/D102494
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
