phosek added inline comments.

================
Comment at: clang/include/clang/Basic/TargetCXXABI.h:69
+  // default.
+  static bool supportsRelativeCXXVTables(const llvm::Triple &T) {
+    return T.isOSFuchsia();
----------------
I think that `supports` here is a bit misleading, I'd expect the return value 
to signal whether relative vtables C++ ABI is supported or not but not control 
the default. Maybe `usesRelativeVTables`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102374/new/

https://reviews.llvm.org/D102374

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to