vsavchenko added a comment.

In D102240#2750976 <https://reviews.llvm.org/D102240#2750976>, @steakhal wrote:

> Dam, we will be always haunted by these.

Yep, it was one place where we didn't expect a null state, but after one of the 
later patches, it became possible. 🤞it's the final one.

> Looks good btw.
> The test looks somewhat artificial - like a raw `creduce` result.
>
> Do you think It worth the effort to make it look like it was written by a 
> human?

OK, I tried. and surprisingly I couldn't transform `c == b` into a condition, 
so it crashes.  While it's interesting why exactly this happens, I don't think 
that it's worth it (in this particular case).

> I also somewhy prefer function parameters to globals for this specific 
> use-case.

✅

> This seems to depend on the `-analyzer-config eagerly-assume=true`. We should 
> probably add this option explicitly, just in case.

✅


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102240/new/

https://reviews.llvm.org/D102240

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to