vsavchenko added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:250 + /// guarantee this. + ContainerType unite(const ContainerType &LHS, const ContainerType &RHS); ---------------- ASDenysPetrov wrote: > vsavchenko wrote: > > `ContainerType` is basically a mutable version of `RangeSet`, so there is > > only one reason to return it - you believe that the users might want to > > modify it after they called this `unite`. But as long as this `unite` is > > just a generalized version of user-facing `unites, it can totally return > > `RangeSet`. > I'm going to use raw ContainerType in further patches. So this is exactly > what I want. Oh, I see. OK then :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
