Author: Christian Kandeler Date: 2021-05-10T14:57:20+02:00 New Revision: f088af37e6b570dd070ae4e6fc14e22d21cda3be
URL: https://github.com/llvm/llvm-project/commit/f088af37e6b570dd070ae4e6fc14e22d21cda3be DIFF: https://github.com/llvm/llvm-project/commit/f088af37e6b570dd070ae4e6fc14e22d21cda3be.diff LOG: [clangd] Fix data type of WorkDoneProgressReport::percentage According to the specification, this should be an unsigned integer. Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D101616 Added: Modified: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/Protocol.h Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp index 913c5c3219a5..c25195cd338f 100644 --- a/clang-tools-extra/clangd/ClangdLSPServer.cpp +++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp @@ -1606,7 +1606,7 @@ void ClangdLSPServer::onBackgroundIndexProgress( if (Stats.Completed < Stats.Enqueued) { assert(Stats.Enqueued > Stats.LastIdle); WorkDoneProgressReport Report; - Report.percentage = 100.0 * (Stats.Completed - Stats.LastIdle) / + Report.percentage = 100 * (Stats.Completed - Stats.LastIdle) / (Stats.Enqueued - Stats.LastIdle); Report.message = llvm::formatv("{0}/{1}", Stats.Completed - Stats.LastIdle, diff --git a/clang-tools-extra/clangd/Protocol.h b/clang-tools-extra/clangd/Protocol.h index 2ae60910639e..f0d46ab8a010 100644 --- a/clang-tools-extra/clangd/Protocol.h +++ b/clang-tools-extra/clangd/Protocol.h @@ -631,7 +631,7 @@ struct WorkDoneProgressReport { /// /// The value should be steadily rising. Clients are free to ignore values /// that are not following this rule. - llvm::Optional<double> percentage; + llvm::Optional<unsigned> percentage; }; llvm::json::Value toJSON(const WorkDoneProgressReport &); // _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
