feg208 added a comment.

In D101868#2745942 <https://reviews.llvm.org/D101868#2745942>, 
@HazardyKnusperkeks wrote:

> Something which just came to my mind. Since you wrote your own LineFormatter, 
> you have to add test cases for all kinds of indention and wrapping. It seems 
> that the string wrapping does not happen, how about comments? Are classes, 
> namespaces, functions, etc. correctly indented with various configurations?
>
> Given my expectations I think the alignment has to happen differently, but 
> I'm happy to be proven wrong.

hmmmmmm I think you are correct. Or at least the path I am going down with 
getting the case of a 20 character column width is demanding adding a bunch of 
things that replicate what is already there. Does a more fruitful avenue look 
something like annotating the tokens?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101868/new/

https://reviews.llvm.org/D101868

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to