alexfh requested changes to this revision. This revision now requires changes to proceed.
================ Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:36 @@ +35,3 @@ + +bool UseNoexceptCheck::helper(const MatchFinder::MatchResult &Result, + const SourceRange &Range, ---------------- The name "helper" doesn't say much. I'm sure we can come up with a much more useful name. The interface could also be more convenient. It looks like this function could return a `FixItHint` (which could possibly be `isNull()`, if no replacement is possible/needed). It could also use an `Optional<FixItHint>` or some other way to inform the caller that there's no action required. http://reviews.llvm.org/D18575 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
