etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Herald added a subscriber: klimek.
The inline keywords are redundant. Introduce by this commit to try to fix broken build bots: http://reviews.llvm.org/D20180 Tested on Debug and Release build [linux]. Tested on Release + Shared (-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON) [linux] Tested on Release [windows] http://reviews.llvm.org/D20189 Files: include/clang/Tooling/FixIt.h Index: include/clang/Tooling/FixIt.h =================================================================== --- include/clang/Tooling/FixIt.h +++ include/clang/Tooling/FixIt.h @@ -40,26 +40,26 @@ /// \brief Returns the SourceRange of an given Node. \p Node is typically a /// 'Stmt', 'Expr' or a 'Decl'. -template <typename T> inline SourceRange getSourceRange(const T &Node) { +template <typename T> SourceRange getSourceRange(const T &Node) { return Node.getSourceRange(); } } // end namespace internal // \brief Returns a textual representation of \p Node. template <typename T> -inline StringRef getText(const T &Node, const ASTContext &Context) { +StringRef getText(const T &Node, const ASTContext &Context) { return internal::getText(internal::getSourceRange(Node), Context); } // \brief Returns a FixItHint to remove \p Node. // TODO: Add support for related syntactical elements (i.e. comments, ...). -template <typename T> inline FixItHint createRemoval(const T &Node) { +template <typename T> FixItHint createRemoval(const T &Node) { return FixItHint::CreateRemoval(internal::getSourceRange(Node)); } // \brief Returns a FixItHint to replace \p Destination by \p Source. template <typename D, typename S> -inline FixItHint createReplacement(const D &Destination, const S &Source, +FixItHint createReplacement(const D &Destination, const S &Source, const ASTContext &Context) { return FixItHint::CreateReplacement(internal::getSourceRange(Destination), getText(Source, Context));
Index: include/clang/Tooling/FixIt.h =================================================================== --- include/clang/Tooling/FixIt.h +++ include/clang/Tooling/FixIt.h @@ -40,26 +40,26 @@ /// \brief Returns the SourceRange of an given Node. \p Node is typically a /// 'Stmt', 'Expr' or a 'Decl'. -template <typename T> inline SourceRange getSourceRange(const T &Node) { +template <typename T> SourceRange getSourceRange(const T &Node) { return Node.getSourceRange(); } } // end namespace internal // \brief Returns a textual representation of \p Node. template <typename T> -inline StringRef getText(const T &Node, const ASTContext &Context) { +StringRef getText(const T &Node, const ASTContext &Context) { return internal::getText(internal::getSourceRange(Node), Context); } // \brief Returns a FixItHint to remove \p Node. // TODO: Add support for related syntactical elements (i.e. comments, ...). -template <typename T> inline FixItHint createRemoval(const T &Node) { +template <typename T> FixItHint createRemoval(const T &Node) { return FixItHint::CreateRemoval(internal::getSourceRange(Node)); } // \brief Returns a FixItHint to replace \p Destination by \p Source. template <typename D, typename S> -inline FixItHint createReplacement(const D &Destination, const S &Source, +FixItHint createReplacement(const D &Destination, const S &Source, const ASTContext &Context) { return FixItHint::CreateReplacement(internal::getSourceRange(Destination), getText(Source, Context));
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits