tlively added inline comments.
================ Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast<GlobalAddressSDNode>(Op)) + return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + ---------------- tlively wrote: > Actually, should we enforce that these LLVM IR globals be thread_local, since > the resulting Wasm globals will be thread_local? I don't know if that will > affect any optimizations, but it seems like a more accurate modeling. If we > do that, `CoalesceLocalsAndStripAtomics::stripThreadLocals` in > WebAssemblyTargetMachine.cpp will have to be updated to not strip the thread > locals corresponding to Wasm globals. I'd be fine handling this in a follow-up if you want to get this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
