Hi,
Thanks for the patch!
This patch is missing a small, lit-style test case. You can find examples of
test cases here:
extra/test/clang-tidy/
Apart from that, my only other nit-pick is that llvm uses 2-space indents, and
spaces between "if" and "(".
If you reply to this list with an updated patch, someone would be happy to
commit it for you.
best
vedant
> On May 11, 2016, at 10:01 AM, Mads Ravn via cfe-commits
> <[email protected]> wrote:
>
> Hi,
>
> I would like to submit a patch for
> https://llvm.org/bugs/show_bug.cgi?id=27400 .
>
> Beside attaching the patch, is there anything I should be aware of? I have
> not submitted a patch before.
>
> You can find the patch attached to this mail.
>
> Kind regards,
> Mads Ravn
> <patch_for_bug_27400.patch>_______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
