aabbaabb marked an inline comment as done. aabbaabb added inline comments.
================ Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + ---------------- wanders wrote: > This overwrites the "bin/scan-build" that was installed from the scan-build > (no -py) subdirectory. > > So with this "scan-build" will suddenly mean the python variant instead of > the per variant. That might be fine (?), but can't be a good idea to have > that done by first installing the perl scan-build and then overwriting it > with the python scan-build. Also the man-page that the perl variant installs > is not overwritten so "man scan-build" will show manual page for the perl > variant. Thanks for the comment. I have renamed scan-build to scan-build-py during installation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
