DNS320 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.cpp:28 + + diag(MatchedForStmt->getBeginLoc(), + "Prefer to declare a loop variable in the initializer part of a " ---------------- Eugene.Zelenko wrote: > It'll be reasonable to add add note with actual variable declaration. The hole check was refactored. A diagnostic hint points now to the statement which modifies the variable. ================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.h:1 +//===--- DeclareLoopVariableInTheInitializerCheck.h - clang-tidy *- C++ -*-===// +// ---------------- Eugene.Zelenko wrote: > I may be mistaken, but proper code is `-*- C++ -*-`. Please remove dash at > left side. Thanks. I checked other header files with long names. I correct it this way, to match the other ones: ``` //===--- DeclareLoopVariableInTheInitializerCheck.h - clang-tidy-*- C++ -*-===// //===--- ProBoundsArrayToPointerDecayCheck.h - clang-tidy--------*- C++ -*-===// ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
