jansvoboda11 accepted this revision.
jansvoboda11 added a comment.

In D101491#2724025 <https://reviews.llvm.org/D101491#2724025>, @delcypher wrote:

> @jansvoboda11 Should I use the the alias feature so that the old 
> `-fsanitize-address-destructor-kind` argument is still parsed? I'm not sure 
> if it's worth it but if doing so is very simple and has a low maintenance 
> burden we should probably do it.

I'm fine with omitting the alias if the original flag didn't make it into a 
release and it's unlikely that downstream TOT users are using it.



================
Comment at: clang/include/clang/Driver/Options.td:1542
   Group<f_clang_Group>;
 def sanitize_address_destructor_kind_EQ
+    : Joined<["-"], "fsanitize-address-destructor=">,
----------------
Nit: remove `_kind` from the def name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101491/new/

https://reviews.llvm.org/D101491

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to