rsmith added a comment.

I agree that this looks wrong.

Does test/Index/cindex-on-invalid.m still pass with this change? (See 
http://reviews.llvm.org/rL129872 in which it was added.) It looks like the 
problem is that we lose the information about whether we're supposed to be 
pointing to the start or the end of the token when we later map to the 
expansion location, which means that libclang's attempt to pretend that source 
ranges are half-open intervals rather than closed intervals breaks.


http://reviews.llvm.org/D20134



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to