mbenfield added a comment.
In D100581#2717182 <https://reviews.llvm.org/D100581#2717182>, @aeubanks wrote:
> I can land this for you, but could you update the description to be a bit
> more descriptive? Explaining what the warnings do.
Are you looking at the updated message in the commit, or the old summary
displayed in Phabricator? It seems Phabricator doesn't change the summary when
I update the commit description. Let me know whether this is what you thought,
or if the current commit message is not adequate. The current commit message is
[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable
These are intended to mimic warnings available in gcc.
-Wunused-but-set-variable is triggered in the case of a variable which
appears on the LHS of an assignment but not otherwise used.
For instance:
void f() {
int x;
x = 0;
}
-Wunused-but-set-parameter works similarly, but for function parameters
instead of variables.
In C++, they are triggered only for scalar types; otherwise, they are
triggered for all types. This is gcc's behavior.
-Wunused-but-set-parameter is controlled by -Wextra, while
-Wunused-but-set-variable is controlled by -Wunused. This is slightly
different from gcc's behavior, but seems most consistent with clang's
behavior for -Wunused-parameter and -Wunused-variable.
Differential Revision: https://reviews.llvm.org/D100581
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100581/new/
https://reviews.llvm.org/D100581
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
