aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from a small nit with the documentation wording.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:5704
+
+This attribute is deprecated. Use clang_builtin_alias instead.
   }];
----------------
I'd like to avoid saying "deprecated" because then people may expect to see 
warnings about use of the ARM attribute. I don't know if the ARM folks are 
ready for it to be officially deprecated as opposed to just discouraged.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100611/new/

https://reviews.llvm.org/D100611

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to