dexonsmith added a comment. > No, the bot is also meant to catch changes to libc++ breaking LLDB (or at > least making sure we update the corresponding data formatters).
> Given that these tests are macOS specific and already require a specific SDK, > I'll just update them to use the compiler from the SDK instead of the > just-built one. I'm not sure I'm totally following, but just want to double check that the tests won't somehow use the libc++ from the SDK instead of ToT? I guess the test uses `-nostdinc++` or something? Assuming that's doing what we want... I also wanted to highlight this adds a dependency on bot's host clang working with the ToT libc++ headers. That's probably fine -- I assume we keep the bot's Xcode relatively up-to-date -- but I know @ldionne at some point was trying to avoid requiring new libc++ to work with older clangs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ https://reviews.llvm.org/D45639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
