JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land.
I misread this as implying loaded_uninitialized for addrspace globals, but actually it's a straightforward oversight from the original implementation. Thanks! ================ Comment at: clang/test/CodeGen/attr-loader-uninitialized.c:21 // CHECK: @i ={{.*}} global %struct.s undef +// CHECK: @j1 ={{.*}}addrspace(1) global %struct.s undef +// CHECK: @j2 ={{.*}}addrspace(2) global %struct.s undef ---------------- addrspace(0) presumably works the same way. Iirc addrspace(0) is different from no addrspace specified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100929/new/ https://reviews.llvm.org/D100929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits