mstorsjo added a comment. In D100937#2704530 <https://reviews.llvm.org/D100937#2704530>, @simon_tatham wrote:
> Yes, it looks easy enough to add something in > `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. > > I'd mildly prefer to do that //as well// as having the test here, because the > call site in the clang driver is quite complicated. My real aim is that > asking for `crypto` (or any other Armv8-specific extension) should actually > get it; I think any accidental regression of that behavior in future is at > least as likely to arise from changes in `clang/lib/Driver` as > `llvm/lib/Support`, so I'd like there to be a test that will detect the > regression if it occurs for //any// reason. Fair enough, that sounds like a reasonable plan to me. Yeah having tests for the actual end results is kinda nice instead of just small broken up unit tests, especially when it isn't something that shouldn't change spuriously (like generated code). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
