arphaman added a comment. In D100807#2702675 <https://reviews.llvm.org/D100807#2702675>, @ab wrote:
> This sounds nice! One idea, maybe more dangerous, not sure which is better: > in `setTripleTypeForMachOArchName`, we already have a couple `setArchName` > calls, I think that's why `arm64e` is left alone in the `aarch64-cpus.c` > test. Maybe we can do the `setArchName` call for every arch there? Thanks for the suggestion! I like your idea better, so I updated the patch. > Another question, probably a completely separate problem: why is it still > reporting darwin? Ideally we'd want it to report macos, right? With that + > your change the triple there would be the actual triple we use to build. > (but maybe the macos bit only comes later when we pick up an SDK in > DarwinClang or whatever?) I think that's the default we set in the build. I do want to get rid of the 'Darwin' triple OS and just leave it as an alias for the driver at some point in the future as I don't think it's serving a good purpose anymore, but I haven't gotten around to it. I can explore using 'macOS' triples for the build before then though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new/ https://reviews.llvm.org/D100807 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
