yaxunl added a comment.
The recent change https://reviews.llvm.org/D96280 caused some difficulty for
this patch. I would like to have some suggestions.
Basically current FE requires any codegen or target option should be uniquely
reproduced from its internal representation. The current patch does not satisfy
the requirement. That's why it fails the pre-merge check.
Currently, the internal representation CodeGenOpt.EmitIEEENaNCompliantInsts is
not uniquely determined by the command line options -m[no]-amdgpu-ieee. It is
also determined by LangOptsRef.NoHonorNaNs. Therefore I cannot regenerate the
original command line option by the value of
CodeGenOpt.EmitIEEENaNCompliantInsts.
One solution I can think of, is to use -mamdgpu-ieee={default|on|off}. This way
I should be able to reproduce the original command line.
Any comments? Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77013/new/
https://reviews.llvm.org/D77013
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
