JonChesterfield added a comment.
Couple of minor points above. I think the increase in error reporting
granularity will be helpful if this falls over in the field, as well as helping
if we need a third try to get through PPC CI
================
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:204
+ if (GPUArch.empty()) {
+ if (auto Err = getSystemGPUArch(DriverArgs, GPUArch)) {
+ std::string ErrMsg =
----------------
Can we reasonably factor out this duplication?
================
Comment at: clang/test/Driver/amdgpu-openmp-system-arch-fail.c:10
+// RUN: cp %S/Inputs/amdgpu-arch/amdgpu_arch_different %t/
+// RUN: echo '#!/bin/true' > %t/amdgpu_arch_empty
+// RUN: chmod +x %t/amdgpu_arch_fail
----------------
I'm not sure we can assume /bin/true exists everywhere, perhaps create a shell
script on the fly that just exits?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99949/new/
https://reviews.llvm.org/D99949
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
