aaron.ballman added a comment.

In http://reviews.llvm.org/D19876#423582, @etienneb wrote:

> Aaron? minus re-generation of the doc.
>  Is that what you want to see?


Yes, this is the direction I was hoping for, thank you!

> note: returned types for both getLength are not the same (APInt vs unsigned 
> int).

>  I took the 'hasSize'-Matcher approach to let overloaded operators do the job 
> for dispatching types.


Perfect!

> note: there is a unittest for top-level node that is no longer valid because 
> stringLiteral can be a top-level node now.


Thank you for that explanation, I was curious about that. :-)


http://reviews.llvm.org/D19876



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to